vogievetsky opened a new pull request #10751:
URL: https://github.com/apache/druid/pull/10751


   The new AutoForm based validator in the web console is a bit too strict. It 
treats every field that is not `undefined` as defined. This causes an issue 
when you set a compaction config:
   
   After you set the initial compaction config:
   
   
![image](https://user-images.githubusercontent.com/177816/104497554-62ba6880-558f-11eb-9389-9b9ceb0c47d6.png)
   
   The config comes back from Druid as:
   
   ```json
   {
     "dataSource": "wiki-test",
     "taskPriority": 25,
     "inputSegmentSizeBytes": 419430400,
     "maxRowsPerSegment": null,
     "skipOffsetFromLatest": "P1D",
     "tuningConfig": {
       "maxRowsInMemory": null,
       "maxBytesInMemory": null,
       "maxTotalRows": null,
       "splitHintSpec": null,
       "partitionsSpec": {
         "type": "dynamic",
         "maxRowsPerSegment": 5000000,
         "maxTotalRows": null
       },
       "indexSpec": null,
       "indexSpecForIntermediatePersists": null,
       "maxPendingPersists": null,
       "pushTimeout": null,
       "segmentWriteOutMediumFactory": null,
       "maxNumConcurrentSubTasks": null,
       "maxRetry": null,
       "taskStatusCheckPeriodMs": null,
       "chatHandlerTimeout": null,
       "chatHandlerNumRetries": null,
       "maxNumSegmentsToMerge": null,
       "totalNumMergeTasks": null,
       "type": "index_parallel",
       "forceGuaranteedRollup": false
     },
     "taskContext": null
   }
   ```
   
   The validator complains that `"totalNumMergeTasks"` is set (to null which is 
not undefined) which does not make sense for the partitionsSpec.type
   
   This is a one line change, with many tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to