zhangyue19921010 edited a comment on pull request #10524: URL: https://github.com/apache/druid/pull/10524#issuecomment-760783961
Hi @himanshug Thanks for your review. I am trying to understand what you suggested: 1. Extract the autoScale logic out of `SeekableStreamSupervisor` to minimize putting more stuff inside there. 2. Make autoscaling algorithm configurable and scalable. These changes are great and useful. I will re-arrange this PR as soon as possible. And I believe it's harder to write UTs and ITs 😅 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
