gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558143595
##########
File path:
processing/src/main/java/org/apache/druid/segment/vector/VectorColumnSelectorFactory.java
##########
@@ -57,6 +57,15 @@ default int getMaxVectorSize()
*/
MultiValueDimensionVectorSelector
makeMultiValueDimensionSelector(DimensionSpec dimensionSpec);
+ /**
+ * Returns an object selector for string columns, useful for non-dictionary
encoded strings, or when
Review comment:
The javadoc here should be fleshed out to describe the expected
contract. IMO it should answer questions like:
- If you call this with a DimensionSpec that refers to a non-string column,
what happens?
- Will the returned VectorObjectSelector always return a String or `null`?
- …might it return List<String> for a multi-value string column?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
