gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r558127972
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java
##########
@@ -27,6 +27,13 @@
{
Predicate<String> makeStringPredicate();
+ default Predicate<Object> makeObjectPredicate()
+ {
+ // default to try to use string predicate;
+ final Predicate<String> stringPredicate = makeStringPredicate();
+ return o -> stringPredicate.apply((String) o);
Review comment:
I think it's worth designing this properly now, so we don't have to go
back and fix it later.
Maybe the right approach is to _not_ add an extra method to
DruidPredicateFactory, and instead have the callers call makeStringPredicate,
because the callers are the ones that should have the knowledge that it's
definitely a String column being dealt with.
Would that work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
