suneet-s commented on a change in pull request #10761:
URL: https://github.com/apache/druid/pull/10761#discussion_r558549684
##########
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java
##########
@@ -366,8 +390,8 @@ private Runnable fetchRecords()
log.error(e, "encounted AWS error while attempting to fetch records,
will not retry");
throw e;
}
- catch (AmazonServiceException e) {
Review comment:
Are there no tests that cover this path? I'm surprised that we didn't
need to make an associated test change somewhere because of this and the change
on line 815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
