techdocsmith commented on a change in pull request #10761: URL: https://github.com/apache/druid/pull/10761#discussion_r568219198
##########
File path: docs/development/extensions-core/kafka-ingestion.md
##########
@@ -197,7 +197,7 @@ The tuningConfig is optional and default parameters will be
used if no tuningCon
| `chatRetries` | Integer | The number of times
HTTP requests to indexing tasks will be retried before considering tasks
unresponsive.
| no (default == 8)
|
| `httpTimeout` | ISO8601 Period | How long to wait for a
HTTP response from an indexing task.
| no (default == PT10S)
|
| `shutdownTimeout` | ISO8601 Period | How long to wait for
the supervisor to attempt a graceful shutdown of tasks before exiting.
| no (default == PT80S)
|
-| `offsetFetchPeriod` | ISO8601 Period | How often the
supervisor queries Kafka and the indexing tasks to fetch current offsets and
calculate lag.
| no (default ==
PT30S, min == PT5S)
|
+| `offsetFetchPeriod` | ISO8601 Period | How often the
supervisor queries Kafka and the indexing tasks to fetch current offsets and
calculate lag. If value provided by user is below the minimum value (`PT5S`),
user provided value is ignored and minimum value is used instead.
| no (default ==
PT30S, min == PT5S)
|
Review comment:
```suggestion
| `offsetFetchPeriod` | ISO8601 Period | How often the
supervisor queries Kafka and the indexing tasks to fetch current offsets and
calculate lag. If the user-specified value is below the minimum value (`PT5S`),
the supervisor ignores the the value and uses the minimum value instead.
| no (default
== PT30S, min == PT5S)
|
```
Missing article "the value"
##########
File path: docs/development/extensions-core/kinesis-ingestion.md
##########
@@ -193,6 +193,7 @@ The tuningConfig is optional and default parameters will be
used if no tuningCon
| `maxSavedParseExceptions` | Integer | When a parse
exception occurs, Druid can keep track of the most recent parse exceptions.
"maxSavedParseExceptions" limits how many exception instances will be saved.
These saved exceptions will be made available after the task finishes in the
[task completion report](../../ingestion/tasks.md#reports). Overridden if
`reportParseExceptions` is set.
| no, default == 0
|
| `maxRecordsPerPoll` | Integer | The maximum number
of records/events to be fetched from buffer per poll. The actual maximum will
be `Max(maxRecordsPerPoll, Max(bufferSize, 1))`
| no, default == 100
|
| `repartitionTransitionDuration` | ISO8601 Period | When shards are
split or merged, the supervisor will recompute shard -> task group mappings,
and signal any running tasks created under the old mappings to stop early at
(current time + `repartitionTransitionDuration`). Stopping the tasks early
allows Druid to begin reading from the new shards more quickly. The repartition
transition wait time controlled by this property gives the stream additional
time to write records to the new shards after the split/merge, which helps
avoid the issues with empty shard handling described at
https://github.com/apache/druid/issues/7600.
| no, (default == PT2M)
|
+| `offsetFetchPeriod` | ISO8601 Period | How often the
supervisor queries Kinesis and the indexing tasks to fetch current offsets and
calculate lag. If value provided by user is below the minimum value (`PT5S`),
user provided value is ignored and minimum value is used instead.
| no (default == PT30S, min == PT5S)
|
Review comment:
```suggestion
| `offsetFetchPeriod` | ISO8601 Period | How often the
supervisor queries Kinesis and the indexing tasks to fetch current offsets and
calculate lag. If the user-specified value is below the minimum value (`PT5S`),
the supervisor ignores the the value and uses the minimum value instead.
| no (default == PT30S, min == PT5S)
|
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
