gianm commented on pull request #10767: URL: https://github.com/apache/druid/pull/10767#issuecomment-763398344
When debugging a test failure, I realized that some additional work is needed to make the aggregator able to handle both complex inputs (existing theta sketches) and regular inputs (strings, primitives). There's some debt that needed to be paid down: - VectorColumnProcessorFactory had to be taught about complex columns, instead of handling them all as all-null string columns - Existing users of VectorColumnProcessorFactory had to be taught about complex columns too - To support the above, makeVectorProcessor needed to be moved from DimensionHandlerUtils to ColumnProcessors and harmonized with the ColumnProcessor stuff ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
