clintropolis commented on a change in pull request #10605:
URL: https://github.com/apache/druid/pull/10605#discussion_r560934713
##########
File path: docs/misc/math-expr.md
##########
@@ -119,13 +119,14 @@ See javadoc of java.lang.Math for detailed explanation
for each function.
|acos|acos(x) would return the arc cosine of x|
|asin|asin(x) would return the arc sine of x|
|atan|atan(x) would return the arc tangent of x|
-|bitwiseAnd|bitwiseAnd(x,y) would return the result of x & y. Double values
will be converted to their bit representation|
-|bitwiseComplement|bitwiseComplement(x) would return the result of ~x. Double
values will be converted to their bit representation|
-|bitwiseConvertDouble|bitwiseConvertDouble(x) would convert the IEEE 754
floating-point "double" bits stored in a long into a double value if the input
is a long, or the copy bits of a double value into a long if the input is a
double.|
-|bitwiseOr|bitwiseOr(x,y) would return the result of x [PIPE] y. Double values
will be converted to their bit representation |
-|bitwiseShiftLeft|bitwiseShiftLeft(x,y) would return the result of x << y.
Double values will be converted to their bit representation|
-|bitwiseShiftRight|bitwiseShiftRight(x,y) would return the result of x >> y.
Double values will be converted to their bit representation|
-|bitwiseXor|bitwiseXor(x,y) would return the result of x ^ y. Double values
will be converted to their bit representation|
+|bitwiseAnd|bitwiseAnd(x,y) would return the result of x & y. Double values
will be implicitly cast to longs, use `bitwiseConvertDoubleToLongBits` to
perform bitwise operations directly with doubles|
+|bitwiseComplement|bitwiseComplement(x) would return the result of ~x. Double
values will be implicitly cast to longs, use `bitwiseConvertDoubleToLongBits`
to perform bitwise operations directly with doubles|
+|bitwiseConvertDoubleToLongBits|bitwiseConvertDoubleToLongBits(x) would
convert the IEEE 754 floating-point "double" bits stored in a long into a
double value if the input is a long, or implicitly cast the value to a long if
the input is a double|
Review comment:
heh no, when I split the functions i deleted the wrong half of the
description .. and then wrote the one i meant to delete again a different way
for the function i split out 🙃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
