loquisgon commented on a change in pull request #10742:
URL: https://github.com/apache/druid/pull/10742#discussion_r562027501
##########
File path:
server/src/test/java/org/apache/druid/segment/indexing/granularity/IntervalsByGranularityTest.java
##########
@@ -76,6 +79,21 @@ public void testDups()
Assert.assertTrue(count == 61);
}
+
+ @Test
+ public void testCondenseDoesNotMaterialize()
Review comment:
It only does indirectly, if it materialized it would create 1 year worth
of seconds amount of intervals (over 31 million). If it materialized I reasoned
that it would slow down the test or something. I can remove it or rename it.
Let me know if you think of a better way to test that. I don't want to measure
memory before and after using the `Runtime.getRuntime()` methods because they
are not very precise either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
