loquisgon commented on a change in pull request #10742:
URL: https://github.com/apache/druid/pull/10742#discussion_r555931298
##########
File path:
server/src/main/java/org/apache/druid/segment/indexing/granularity/UniformGranularitySpec.java
##########
@@ -57,18 +60,17 @@ public UniformGranularitySpec(
this.segmentGranularity = segmentGranularity == null ?
DEFAULT_SEGMENT_GRANULARITY : segmentGranularity;
if (inputIntervals != null) {
- List<Interval> granularIntervals = new ArrayList<>();
- for (Interval inputInterval : inputIntervals) {
- Iterables.addAll(granularIntervals,
this.segmentGranularity.getIterable(inputInterval));
- }
- this.inputIntervals = ImmutableList.copyOf(inputIntervals);
- this.wrappedSpec = new ArbitraryGranularitySpec(queryGranularity,
rollup, granularIntervals);
+ // sort them
Review comment:
Contract indicates that inputIntervals must be left "as is".... will
remove sorting in next commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
