loquisgon opened a new pull request #10856:
URL: https://github.com/apache/druid/pull/10856


   ### Current behavior
   When two or more segments are compacted the new compacted segment’s query 
granularity is null regardless of the query granularities of the segments that 
were compacted.
   
   ### Expected behavior
   When two or more segments are compacted the new compacted segment’s query 
granularity should reflect the query granularities of the  segments that were 
compacted. If all the  segments that were compacted had the same query 
granularity then the compacted segment will have the same query granularity 
when at least one segment’s granularity is non-null. If the compacted segments 
had different query granularities then the compacted segment will have the 
finer of all the granularities. We will use the existing method of class 
Granularities: List<Granularity> granularitiesFinerThan(final Granularity 
gran0) to determine that.
   
   ### Reasoning of why we decided the expected behavior
   When the compacted segments have the same query granularity the expected 
behavior makes sense without controversy. However when the query granularities 
of the segments that were compacted are different there are various choices. 
One choice is to pick the coarsest granularity. We decided against this because 
this is a destructive operation on some records of the segments that were 
compacted. Another choice is to use a configuration dependent flag. We decided 
against this so we give ourselves more time to learn about the data lifecycle 
management use cases. We will revisit this decision at a later point.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to