bananaaggle commented on a change in pull request #10839:
URL: https://github.com/apache/druid/pull/10839#discussion_r571512005
##########
File path:
extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/ProtobufInputRowParser.java
##########
@@ -37,39 +32,32 @@
import org.apache.druid.data.input.MapBasedInputRow;
import org.apache.druid.data.input.impl.JSONParseSpec;
import org.apache.druid.data.input.impl.ParseSpec;
-import org.apache.druid.java.util.common.StringUtils;
+import org.apache.druid.java.util.common.logger.Logger;
import org.apache.druid.java.util.common.parsers.ParseException;
import org.apache.druid.java.util.common.parsers.Parser;
import org.apache.druid.utils.CollectionUtils;
-import java.io.IOException;
-import java.io.InputStream;
-import java.net.MalformedURLException;
-import java.net.URL;
import java.nio.ByteBuffer;
import java.util.List;
import java.util.Map;
-import java.util.Set;
public class ProtobufInputRowParser implements ByteBufferInputRowParser
{
+ private static final Logger LOG = new Logger(ByteBufferInputRowParser.class);
+
private final ParseSpec parseSpec;
- private final String descriptorFilePath;
- private final String protoMessageType;
- private Descriptor descriptor;
+ private final ProtobufBytesDecoder protobufBytesDecoder;
private Parser<String, Object> parser;
private final List<String> dimensions;
@JsonCreator
public ProtobufInputRowParser(
@JsonProperty("parseSpec") ParseSpec parseSpec,
- @JsonProperty("descriptor") String descriptorFilePath,
- @JsonProperty("protoMessageType") String protoMessageType
+ @JsonProperty("protoBytesDecoder") ProtobufBytesDecoder
protobufBytesDecoder
Review comment:
Good idea, I'll implement it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
