clintropolis commented on a change in pull request #10839:
URL: https://github.com/apache/druid/pull/10839#discussion_r580040921
##########
File path: distribution/bin/check-licenses.py
##########
@@ -225,6 +225,9 @@ def build_compatible_license_names():
compatible_licenses['Apache License v2.0'] = 'Apache License version 2.0'
compatible_licenses['Apache License, version 2.0'] = 'Apache License
version 2.0'
compatible_licenses['Apache 2.0 License'] = 'Apache License version 2.0'
+ compatible_licenses['Apache License, 2.0'] = 'Apache License version 2.0'
+ compatible_licenses['Confluent Community License'] = 'Confluent Community
License'
Review comment:
I looked at the source files for `kafka-protobuf-provider` here,
https://github.com/confluentinc/schema-registry/tree/master/protobuf-provider/src/main/java/io/confluent/kafka/schemaregistry/protobuf
and there appears to be a mix of Apache and Confluent Community License
headers, which I assume it means both licenses apply.
Unfortunately, I _think_ this means that we cannot distribute this jar, but
I think that instead we can provide instructions in the documentation on how
users can download it (see
https://www.apache.org/legal/resolved.html#optional), similar to how we do with
the MySQL connector.
The `pom.xml` will need to mark this jar as provided, and you will need to
remove this license from this python script, and remove
`kafka-protobuf-provider` from `license.yaml`. I think maybe it is ok if tests
still depend on it, since it wouldn't cause packaging to distribute it? but i'm
unsure exactly...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
