lkm commented on a change in pull request #10543:
URL: https://github.com/apache/druid/pull/10543#discussion_r572769034
##########
File path:
sql/src/test/java/org/apache/druid/sql/avatica/DruidAvaticaHandlerTest.java
##########
@@ -101,7 +101,7 @@
import java.util.concurrent.Executors;
import java.util.concurrent.ThreadLocalRandom;
-public class DruidAvaticaHandlerTest extends CalciteTestBase
+public abstract class DruidAvaticaHandlerTest extends CalciteTestBase
Review comment:
Would that not make the test harder to read? You mean parameterising
each test case? I was going for a lighter touch approach, the abstracted
methods are called in setUp, which would then need rewriting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
