lkm commented on a change in pull request #10543:
URL: https://github.com/apache/druid/pull/10543#discussion_r572792409



##########
File path: 
server/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java
##########
@@ -457,6 +470,95 @@ static String getAvaticaConnectionId(Map<String, Object> 
requestMap)
     return (String) connectionIdObj;
   }
 
+  static String getAvaticaProtobufConnectionId(Service.Request request)

Review comment:
       I'm not sure how much there is to gain from that, what are you thinking 
would be the advantage? Also, looking through it I can't find an easy to use 
class like ProtobufTranslationImpl for json.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to