jihoonson commented on a change in pull request #10885:
URL: https://github.com/apache/druid/pull/10885#discussion_r575581693



##########
File path: licenses.yaml
##########
@@ -157,6 +157,15 @@ libraries:
 
 ---
 
+name: Code adopted from org.apache.commons.dbcp2.BasicDataSource
+license_category: source
+module: server
+license_name: Apache License version 2.0
+source_paths:
+  - server/src/main/java/org/apache/druid/metadata/BasicDataSourceExt.java

Review comment:
       Can you please add a notice here too? I think the notice of Apache 
projects should be bubbled up into ours. See 
https://infra.apache.org/licensing-howto.html for more details. The notice for 
commons-dbcp can be found in 
https://github.com/apache/commons-dbcp/blob/master/NOTICE.txt.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to