jihoonson commented on a change in pull request #10885:
URL: https://github.com/apache/druid/pull/10885#discussion_r577268266
##########
File path: licenses.yaml
##########
@@ -157,6 +157,15 @@ libraries:
---
+name: Code adopted from org.apache.commons.dbcp2.BasicDataSource
+license_category: source
+module: server
+license_name: Apache License version 2.0
+source_paths:
+ - server/src/main/java/org/apache/druid/metadata/BasicDataSourceExt.java
Review comment:
Since it's been long to update this source license, the update process
was not clear to me as well. I wrote some in
https://github.com/apache/druid/pull/10894. Based on the [instructions in that
PR](https://github.com/apache/druid/pull/10894/files#diff-e0657fbb35e792bf869c4bd37b330e5bd8ad37b426296f153839512d25dbcf39R48),
you need to update the `LICENSE` and `NOTICE` files for source code packages
as well since they are currently managed manually. Also, the CI failure seems
legit as the version is missing here.
```
=== Generating the contents of NOTICE.BINARY file ===
/home/travis/build/apache/druid/distribution/bin/generate-binary-notice.py:60:
YAMLLoadWarning: calling yaml.load_all() without Loader=... is deprecated, as
the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full
details.
dependencies = list(yaml.load_all(registry_file))
Traceback (most recent call last):
File
"/home/travis/build/apache/druid/distribution/bin/generate-binary-notice.py",
line 88, in <module>
generate_notice(source_notice, dependencies_yaml)
File
"/home/travis/build/apache/druid/distribution/bin/generate-binary-notice.py",
line 72, in generate_notice
print_notice(dependency)
File
"/home/travis/build/apache/druid/distribution/bin/generate-binary-notice.py",
line 40, in print_notice
print_outfile("{} {} {} {}".format(dependencyHeaderLine,
dependency['name'], dependency['version'], dependencyHeaderLine))
KeyError: 'version'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
