abhishekagarwal87 commented on pull request #10892: URL: https://github.com/apache/druid/pull/10892#issuecomment-780352536
> Another thing: I see that `asImmutable` doesn't just return an immutable copy, it also calls `OvershadowableManager.copyVisible` to potentially not return all of the chunks. So cutting out the call to `asImmutable` would also cut out the call to `copyVisible`. I'm not sure what consequences that might have. Have you analyzed it and determined that it's OK to cut out that call? Good catch. As far as I can tell, cutting down that call should not make a difference. `copyVisible` retains only visible chunks in `knownPartitionChunks`. However, in the `getChunk` call too, we are only returning a chunk if its visible. There shouldn't be a mismatch in behavior after the change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
