abhishekagarwal87 commented on pull request #10892: URL: https://github.com/apache/druid/pull/10892#issuecomment-780354748
> @abhishekagarwal87 Another idea I had is in the `CachingClusteredClient.getQueryRunnerForSegments` we can cache the result returned from `timeline.findEntry(spec.getInterval(), spec.getVersion())`. We can maintains a map while iterating through all the input `specs` and cache returned `PartitionHolder<ServerSelector>` for the interval/version pair. This is useful when the `Iterable<SegmentDescriptor> specs` contains a lot of same interval/version pair. For example, if new there are a lot of segments per interval, the specs can contains pretty much all a single interval/version pair. yeah, I thought about that too. I didn't go ahead with that approach since that would require creating a new temporary state variable. For queries with many intervals, it could be that we end up creating many map entries with deep copies of `OvershawdoableManager`. what do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
