zachjsh commented on a change in pull request #10896:
URL: https://github.com/apache/druid/pull/10896#discussion_r581261777
##########
File path:
extensions-core/druid-basic-security/src/test/java/org/apache/druid/security/BasicAuthUtilsTest.java
##########
@@ -36,4 +51,112 @@ public void testHashPassword()
Assert.assertEquals(BasicAuthUtils.SALT_LENGTH, salt.length);
Assert.assertEquals(BasicAuthUtils.KEY_LENGTH / 8, hash.length);
}
+
+ @Test
+ public void testPermissionSerdeIsChillAboutUnknownEnumStuffs() throws
JsonProcessingException
Review comment:
this test seems to test 3 cases: 1 good Permission, one bad resourceType
permission and one bad resourceAciont permission. Thought it made sens to split
into 3 tests accordingly. Its ok to leave as is too, just a nit, no biggie.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
