clintropolis opened a new pull request #10929:
URL: https://github.com/apache/druid/pull/10929


   ### Description
   
   Builds on top of #10314 to add an integration test using a schema-registry 
docker container to test Apache Kafka + Apache Avro + Confluent Schema Registry 
secured with basic auth. This container only runs when the `kafka-data-format` 
integration test group is run.
   
   I also adjusted the parse method to distinguish failures to get the Avro 
schema from the registry from actual parse exceptions, since it seems like 
failure to get the schema would cause no messages to ever be parsable.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] added integration tests.
   - [x] been tested in a test Druid cluster.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to