zhangyue19921010 edited a comment on pull request #10524: URL: https://github.com/apache/druid/pull/10524#issuecomment-791153724
> Not able to give a full detailed review right now so I will just comment. Left 3 comments. The only one that would be a blocker for merge is the licenses comment. I want to make sure we handle that correctly according to the document I linked in the comment. > > Overall the code looks good to me and I think the idea is sound and implementation looks logical and extensible Hi @capistrant . Thanks for your review. All the changes are done. As for `licenses`,`<artifactId>commons-collections4</artifactId> version: 4.2` is already added into licenses.yaml before. If i am correct, it wouldn't be a blocker :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
