zhangyue19921010 edited a comment on pull request #10524: URL: https://github.com/apache/druid/pull/10524#issuecomment-783939532
> I think when autoscaler is enabled, `taskCount` should be ignored and setting `taskCountMax` and `taskCountMin` should be required and there should not be any default values for these two counts. `taskCountMin` will be the number of tasks that ingestion starts going up to `taskCountMax`, validation of `taskCountMax` >= `taskCountMin` should be added. This behaviour should be documented as well. All changed. Thanks for your review. 1. When autoscaler is enabled, taskCount in IOConfig is ignored and taskCountMin will be the number of tasks that ingestion starts going up to taskCountMax. 2. Setting taskCountMax and taskCountMin is required and there are no default values for these two counts. 3. Validation of taskCountMax >= taskCountMin is added. 4. All behaviors are documented. Hi @pjain1 could you please take a look? Thanks a lot. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
