FrankChen021 opened a new pull request #10949:
URL: https://github.com/apache/druid/pull/10949
Fixes #10702
### Description
This PR fixes #10702 by adding support to doubleFirst/floatFirst/longFirst
and doubleLast/floatLast/longLast during ingestion phase. And also reverts
#10794 to bring back the UI.
The implementation is inspired by current stringFirst/stringLast
implementation, so the code looks like similar. But this PR does not refactor
current stringFirst/stringLast implementation to share the code with
double/float/long. That might be done in the future.
<hr>
##### Key changed/added classes in this PR
* `AbstractSerializablePairSerde` is provided to share serialization code
for type of long/double/float
* `GenericFirstAggregateCombiner` is provided to share first aggregator
code for type of long/double/float
* `GenericLastAggregateCombiner` is provided to share last aggregator code
for type of long/double/float
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [X] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [X] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [X] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [X] added integration tests.
- [X] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
