abhishekagarwal87 commented on a change in pull request #10892:
URL: https://github.com/apache/druid/pull/10892#discussion_r589204110
##########
File path:
core/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java
##########
@@ -284,15 +286,15 @@ private void addAll(
@Override
@Nullable
- public PartitionHolder<ObjectType> findEntry(Interval interval, VersionType
version)
+ public PartitionChunk<ObjectType> findChunk(Interval interval, VersionType
version, int partitionNum)
{
lock.readLock().lock();
try {
for (Entry<Interval, TreeMap<VersionType, TimelineEntry>> entry :
allTimelineEntries.entrySet()) {
if (entry.getKey().equals(interval) ||
entry.getKey().contains(interval)) {
TimelineEntry foundEntry = entry.getValue().get(version);
if (foundEntry != null) {
- return foundEntry.getPartitionHolder().asImmutable();
Review comment:
Looks like its not. will delete this method as well as the class
ImmutablePartitionHolder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
