maytasm opened a new pull request #10962: URL: https://github.com/apache/druid/pull/10962
Fix streaming ingestion fails if it encounters empty rows (Regression) ### Description This is a regression in the JSON inputFormat when use with streaming ingestion, introduced by https://github.com/apache/druid/pull/10383 Streaming ingestion task will consistently fails when it try to parse an empty row despite not reaching maxParseExceptions yet. This is because when the task try to parse an empty row, it does not result in a ParseException but resulted in java.util.NoSuchElementException instead. Hence, the task will fail and will not be able to move pass the empty row even with maxParseExceptions set. This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [x] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
