maytasm commented on a change in pull request #11000:
URL: https://github.com/apache/druid/pull/11000#discussion_r595491907
##########
File path:
server/src/test/java/org/apache/druid/server/coordinator/duty/NewestSegmentFirstPolicyTest.java
##########
@@ -642,6 +642,33 @@ public void testIteratorDoesNotReturnCompactedInterval()
Assert.assertFalse(iterator.hasNext());
}
+ @Test
+ public void
testIteratorReturnsAllMixedVersionSegmentsInConfiguredSegmentGranularity()
+ {
+ final VersionedIntervalTimeline<String, DataSegment> timeline =
createTimeline(
+ new
SegmentGenerateSpec(Intervals.of("2017-10-01T00:00:00/2017-10-02T00:00:00"),
new Period("P1D"), "1994-04-29T00:00:00.000Z"),
+ new
SegmentGenerateSpec(Intervals.of("2017-10-01T00:01:00/2017-10-01T00:02:00"),
new Period("PT1H"), "1994-04-30T00:00:00.000Z")
Review comment:
Thanks for the review. I'll fix the nit in test in a separate PR as it
doesn't matter for the purpose of this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
