clintropolis commented on pull request #11018: URL: https://github.com/apache/druid/pull/11018#issuecomment-817604685
>As for integration test, should I add it in this PR or other PR after this PR is merged? I think it would be fine to do the integration test as a follow-up, since it is a bit more involved than the Avro input format due to there not being an existing integration test for protobuf. Adding it would be pretty similar to what is already there for Avro and the other formats though, with the main bit being implementing [`EventSerializer`](https://github.com/apache/druid/blob/master/integration-tests/src/main/java/org/apache/druid/testing/utils/EventSerializer.java) for the protobuf input format to test so that data can be written to the stream, and adding all the json template resources so that it gets added to the "data format" test group. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
