loquisgon opened a new pull request #11123:
URL: https://github.com/apache/druid/pull/11123
### Description
Currently native batch ingestion may run out of memory while ingesting files
with lots of logical segments (i.e. Sinks) and multiple physical segments (i.e.
FireHydrants) per sink. Memory profiling indicates that one source of memory
consumption is the references to memory mapped files being created as
firehydrants are created. This will avoid memory mapping firehydrants during
segment creation for native batch ingestion and dropping the memory mapping
right after they are merged.
The fix is relatively simple. Make the `QueriableIndexSegment` lazy by
memoizing the backing index. In addition, just drop the `QueriableIndexSegment`
from the fire hydrant just after a given sink is merged.
##### Key changed/added classes in this PR
* `QueryableIndexSegment`: Make it lazy loading
<hr>
This PR has:
- [ X] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [X ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ X] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
