loquisgon commented on a change in pull request #11123:
URL: https://github.com/apache/druid/pull/11123#discussion_r616109925
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -347,7 +348,8 @@ public AppenderatorAddResult add(
}
}
- if (!skipBytesInMemoryOverheadCheck && bytesCurrentlyInMemory.get() -
bytesToBePersisted > maxBytesTuningConfig) {
+ if (!skipBytesInMemoryOverheadCheck
Review comment:
Good catch... I did not see memory being mapped in my tests but it was
because I had "skipBytesInMemoryOverheadCheck": true in the ingestion spec....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
