jihoonson commented on a change in pull request #11084:
URL: https://github.com/apache/druid/pull/11084#discussion_r616059755



##########
File path: docs/operations/metrics.md
##########
@@ -256,6 +256,8 @@ These metrics are for the Druid Coordinator and are reset 
each time the Coordina
 |`interval/skipCompact/count`|Total number of intervals of this datasource 
that are skipped (not eligible for auto compaction) by the auto 
compaction.|datasource.|Varies.|
 |`coordinator/time`|Approximate Coordinator duty runtime in milliseconds. The 
duty dimension is the string alias of the Duty that is being run.|duty.|Varies.|
 |`coordinator/global/time`|Approximate runtime of a full coordination cycle in 
milliseconds. The `dutyGroup` dimension indicates what type of coordination 
this run was. i.e. Historical Management vs Indexing|`dutyGroup`|Varies.|
+|`metadata/kill/audit/count`|Total number of audit logs deleted from metadata 
store audit table.| |Varies.|

Review comment:
       > The metric can give the user an idea of how many audit logs are being 
automatically deleted. Basically how many audit logs do they have within the 
duration configured. This can help them get a sense if they want to increase or 
decrease the durationToRetain. 
   
   Thanks for the explanation. Could you please explain this in the doc as 
well? Also please mention that this metric is emitted only when 
`druid.coordinator.kill.audit.on` is set to true.

##########
File path: docs/configuration/index.md
##########
@@ -746,10 +746,10 @@ These Coordinator static configurations can be defined in 
the `coordinator/runti
 
 |Property|Description|Required?|Default|
 |--------|-----------|---------|-------|
-|`druid.coordinator.period.metadataStoreManagementPeriod`|How often to run 
metadata management tasks. |No |PT3600S (1 hour)|
+|`druid.coordinator.period.metadataStoreManagementPeriod`|How often to run 
metadata management tasks in [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601) 
duration format. |No | PT1H|

Review comment:
       The doc CI fails because of `PT1H`. One way to avoid the spell check for 
such variables is wrapping them with backticks (`` ` ``).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to