maytasm commented on a change in pull request #11084:
URL: https://github.com/apache/druid/pull/11084#discussion_r616973160
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java
##########
@@ -51,6 +55,14 @@
@Default("0")
public abstract int getCoordinatorKillMaxSegments();
+ @Config("druid.coordinator.kill.audit.period")
+ @Default("P1D")
+ public abstract Duration getCoordinatorAuditKillPeriod();
+
+ @Config("druid.coordinator.kill.audit.durationToRetain")
+ @Default("PT-1s")
Review comment:
Fixed the docs.
`druid.coordinator.kill.audit.period` is not required. And the default value
is P1D
`druid.coordinator.kill.audit.durationToRetain` is required. The default
value which is -1 which causes the precondition check to fail. User should set
it to a positive value. Instead of putting in the docs that the default value
is -1 and that Coordinator will fail if value is negative, for simplicity, I
just documented that default value is None and user must set this value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
