capistrant commented on a change in pull request #11135:
URL: https://github.com/apache/druid/pull/11135#discussion_r620478702



##########
File path: 
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -176,6 +184,22 @@ public CoordinatorDynamicConfig(
     }
     this.pauseCoordination = pauseCoordination;
     this.replicateAfterLoadTimeout = replicateAfterLoadTimeout;
+
+    if (maxNonPrimaryReplicantsToLoad == null) {

Review comment:
       Hmm, I think I would be ok with that. I don't see any valid use case 
where a value of 0 would be required by the user. At that point they would want 
to disable replication via load rules.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to