loquisgon commented on a change in pull request #11123:
URL: https://github.com/apache/druid/pull/11123#discussion_r620731258
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/FireHydrant.java
##########
@@ -34,17 +34,53 @@
import javax.annotation.Nullable;
import java.io.Closeable;
+import java.io.File;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.Function;
/**
+ *
*/
public class FireHydrant
{
private final int count;
private final AtomicReference<ReferenceCountingSegment> adapter;
private volatile IncrementalIndex index;
+ private File persistedFile;
+ private SegmentId persistedSegmentId;
+
+ /**
+ * @return The persisted file path. This is needed to recreate mapped files
before merging.
+ * it will be null for real time hydrants.
+ */
+ public @Nullable File getPersistedFile()
+ {
+ return persistedFile;
+ }
+
+ /**
+ * @return The persisted segment id. This is needed to recreate mapped files
before merging.
+ * It will be null for real time hydrants
+ */
+ public @Nullable SegmentId getPersistedSegmentId()
Review comment:
In order to make the code less confusing I can still keep the
`persistedSegmentId` reference but modify the `getSegmentId` method as follows:
` public SegmentId getSegmentId()
{
if (adapter.get() != null) {
return adapter.get().getId();
} else {
return persistedSegmentId;
}
}`
Would you prefer this instead? Personally I prefer the explicit way to
obtain that reference but the fact that there are so many questions already
makes it clear that it is confusing. So I am fine with an alternative. Let me
know if the original way, or the above works or whether you have a better idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
