ericxiao251 commented on issue #10644:
URL: https://github.com/apache/druid/issues/10644#issuecomment-840644078


   > Or is this just confusion since none of this was previously explicitly 
documented so the only reference was the documentation on the two null handling 
modes?
   
   @clintropolis ah I missed the new documentation you created! I think that is 
exactly it, the documentation on the druid homepage (not Github) doesn't 
explain clearly the expected behaviour for the various aggregate functions and 
their defaults. If we could link your new documentation somewhere in the druid 
website in this section that would be great: 
https://druid.apache.org/docs/latest/configuration/index.html#sql-compatible-null-handling.
 I can put a PR up for that :).
   
   ---
   
   I don't think I fully understand the downstream complications of an 
aggregation returning a null value, so I also don't have strong opinions about 
what the value should be when we see a null value.
   
   When an aggregate result overflows, what are the results? Would it be 
`LONG.MIN_VALUE`/`LONG.MAX_VALUE` for example? Would this be the only confusing 
scenario if we used the two min and max values?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to