clintropolis commented on pull request #11126: URL: https://github.com/apache/druid/pull/11126#issuecomment-841760596
>Hi, @clintropolis, I've solved problems. It caused by static DynamicMessage.Builder, I fixed it and all tests can pass. Glad you figured it out! The PR looks good to me, but [the spotbugs check is failing](https://travis-ci.com/github/apache/druid/jobs/505652794#L1427): ``` [ERROR] High: org.apache.druid.testing.utils.ProtobufEventSerializer.SCHEMA isn't final but should be [org.apache.druid.testing.utils.ProtobufEventSerializer] At ProtobufEventSerializer.java:[line 61] MS_SHOULD_BE_FINAL ``` I did manually trigger the kafka format integration tests and they passed, so after the spotbugs thing is fixed up I think it should be good to merge :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
