kfaraz commented on a change in pull request #11190:
URL: https://github.com/apache/druid/pull/11190#discussion_r634527922
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java
##########
@@ -154,6 +160,17 @@ public DruidCoordinatorRuntimeParams
run(DruidCoordinatorRuntimeParams params)
}
}
+ // Skip all the locked intervals
+ LOG.debug(
+ "Skipping the following intervals for Compaction as they are
currently locked: %s",
+ taskToLockedIntervals
+ );
+ taskToLockedIntervals.forEach(
Review comment:
For simplicity, we are treating Segment Locks the same as Time Chunk
Locks i.e. the whole interval would be skipped while submitting compaction
tasks even if there is just one Segment in that interval that is locked by a
higher priority task.
Added this as a javadoc comment here:
https://github.com/apache/druid/blob/a8e30c3c8c9c2b58b0615f3f50d863c334cadd75/server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java#L233
https://github.com/apache/druid/blob/a8e30c3c8c9c2b58b0615f3f50d863c334cadd75/indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java#L690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
