maytasm commented on pull request #11190: URL: https://github.com/apache/druid/pull/11190#issuecomment-862073584
- Can you add a test in ITAutoCompactionLockContentionTest that verify that setting the new flag `druid.coordinator.compaction.skipLockedIntervals` to false will actually disable this new feature. - Actually if getLockedIntervalsToSkip does return lock of Compaction task, then you will need https://github.com/apache/druid/pull/11190#discussion_r625757970 (as you mentioned, in CompactSegments.run(), some currently running compaction tasks can get cancelled and hence we have to return the lock) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
