xvrl commented on pull request #11079: URL: https://github.com/apache/druid/pull/11079#issuecomment-846455108
> There are many integration tests that don't run on Travis because they require extra setups such as s3 credentials and a bucket. Should we resolve this issue first? @jihoonson if we don't have a good way of catching these things today as part of our CI builds, I'm not sure there is a difference between automation or humans submitting PRs. We still need to approve these changes before they get merged, so I would hope that we don't approve upgrades if we are aware that it might affect some of those tests. We can of course exclude any dependencies that we know lack good integration test coverage to be safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
