vogievetsky opened a new pull request #11308: URL: https://github.com/apache/druid/pull/11308
Fixes an issue where a compaction spec, reflected back from Druid, with hashed partitioning will not validate in the compaction dialog. This is due to the fact that `maxRowsPerSegment` was renamed to `targetRowsPerSegment` but when Druid sends back the compaction config with `targetRowsPerSegment` becomes `maxRowsPerSegment`. As a result `maxRowsPerSegment` is not fully deprecated and must still be surfaced in the form for correct validation. In addition to the above this PR also makes the following fixes: - It is now possible to add a hidden field to the AutoForm. This means it can be validated correctly but will not surface in the form. This is needed for when `targetRowsPerSegment` will fully replace `maxRowsPerSegment` as we will still need to declare `maxRowsPerSegment` (as hidden) for the validation to work well with old configs that still use `maxRowsPerSegment`. - The `Submit` button will now be disabled if there is an erroneous JSON state in JSON inputs. Preventing the user from being able to paste an invalid JSON and hit submit (submitting the default config). - `Date` serialization was fixed in CSV/TSV download This PR has: - [x] been self-reviewed. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
