bananaaggle commented on pull request #11276: URL: https://github.com/apache/druid/pull/11276#issuecomment-849414875
> IMO, there should be an IT case to cover this change. But since there's no IT integration for community contributed extensions, currently we don't have to do so. > > And for the changes in this PR, any javadoc to describe why `NoopQuerySegmentWalker` should be binded in router is useful. Good suggestion! I will add javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
