FrankChen021 opened a new pull request #11333:
URL: https://github.com/apache/druid/pull/11333


   
   ### Background
   
   #10203 introduces a human readable way to configure values of some 
byte-related properties. In that PR, two different standard unit systems are 
supported: [decimal format and binary 
format](https://en.wikipedia.org/wiki/Binary_prefix). 
   
   The former one is a unit system based on powers of 10(also known as SI 
format), while the latter one is based on powers of 2(also knowns as IEC 
format). For example, 1KB = 1000 bytes while 1KiB = 1024 bytes.
   
   But in old days, KB/MB/GB are also used to express values based on power of 
2, which causes ambiguities. If there's an a word `64MB`, it's hard to tell 
whether it is `64 * 1000 * 100 * 1000` or `64 * 1024 * 1024 * 1024`.
   
   ### Description
   
   This PR tidies up all KB/MB/GB usages in the doc and javadoc to use the 
right unit system based on the code. 
   After this PR, **all KB/MB/GB in the doc/javadoc are decimal format**.  And 
all the doc/javadoc in the future should use the right unit system. 
   
   Generally speaking, for the disk size/file size/segment size, decimal format 
is used, while for other values, binary format is applied.
   
   This PR has:
   - [X] been self-reviewed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to