sthetland commented on a change in pull request #11333:
URL: https://github.com/apache/druid/pull/11333#discussion_r659060551
##########
File path: docs/tutorials/cluster.md
##########
@@ -337,11 +337,11 @@ MiddleManager (Single-server)
```
druid.worker.capacity=8
druid.indexer.fork.property.druid.processing.numMergeBuffers=2
-druid.indexer.fork.property.druid.processing.buffer.sizeBytes=100000000
+druid.indexer.fork.property.druid.processing.buffer.sizeBytes=100MiB
Review comment:
As in previous comment. Might be better to keep in the original form,
just to match the config files as shipped to avoid confusion.
##########
File path: docs/tutorials/cluster.md
##########
@@ -361,17 +361,17 @@ The resulting configs after the split:
New Historical (on 2 Data servers)
```
- druid.processing.buffer.sizeBytes=500000000
- druid.processing.numMergeBuffers=8
- druid.processing.numThreads=31
+druid.processing.buffer.sizeBytes=500MiB
Review comment:
Here too, if reverting the change above, along with line 374 below
##########
File path: docs/tutorials/cluster.md
##########
@@ -322,12 +322,12 @@ You can copy your existing `coordinator-overlord` configs
from the single-server
#### Data
-Suppose we are migrating from a single-server deployment that had 32 CPU and
256GB RAM. In the old deployment, the following configurations for Historicals
and MiddleManagers were applied:
+Suppose we are migrating from a single-server deployment that had 32 CPU and
256GiB RAM. In the old deployment, the following configurations for Historicals
and MiddleManagers were applied:
Historical (Single-server)
```
-druid.processing.buffer.sizeBytes=500000000
+druid.processing.buffer.sizeBytes=500MiB
Review comment:
This change and the next one are lines from the single server small
configuration file, so it might be clearer to leave them in their original
form, so that they match the config files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
