capistrant commented on pull request #11394: URL: https://github.com/apache/druid/pull/11394#issuecomment-872586946
> FWIW, I think it's a useful enough metric to be added to the default set. It will let you see the spread of queries in terms of #segments. If it's not enabled by default, how is the metric going to be enabled? I glanced through the linked discussion and it seems configuration is the recommended option. is that the plan or do you already have a custom extension for metrics? As of this PR, the operator would either need to edit the code and build from source or add an extension. Neither of which is a user friendly approach. But going the configuration route would be a major undertaking since important design decisions will need to be made and reviewed to make sure it is setup in a way that makes sense. Other metrics such as, https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java#L262, are setup like this PR is right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
