jihoonson commented on a change in pull request #11394:
URL: https://github.com/apache/druid/pull/11394#discussion_r665858849



##########
File path: 
server/src/main/java/org/apache/druid/client/CachingClusteredClient.java
##########
@@ -369,6 +373,8 @@ private ClusterQueryResult(Sequence<T> sequence, int 
numQueryServers)
 
       query = scheduler.prioritizeAndLaneQuery(queryPlus, segmentServers);
       queryPlus = queryPlus.withQuery(query);
+      queryPlus = queryPlus.withQueryMetrics(toolChest);
+      
queryPlus.getQueryMetrics().reportQueriedSegmentCount(segmentServers.size()).emit(emitter);

Review comment:
       `RetryQueryRunner` is responsible for re-routing the query to new homes 
of segments if they are moved during query processing. It uses 
`CachingClusteredClient` for re-routing. As a result, this can report the same 
segments multiple times if those segments are moved. I think this is OK and 
worth documenting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to