FrankChen021 commented on a change in pull request #11433:
URL: https://github.com/apache/druid/pull/11433#discussion_r667812561
##########
File path: docs/ingestion/index.md
##########
@@ -309,8 +309,8 @@ Example ingestion spec for task type `index_parallel`
(native batch):
},
"dimensionsSpec": {
"dimensions": [
- { "type": "string", "page" },
- { "type": "string", "language" },
+ { "type": "string", "name": "page" },
Review comment:
I think we could use "page" directly instead of an json object. See Line
448 and 472 of this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
