JulianJaffePinterest commented on pull request #10920: URL: https://github.com/apache/druid/pull/10920#issuecomment-879632108
@jihoonson @samarthjain has been reviewing the pr but yes I agree it's too large to effectively review. I'm not sure how to reduce it to pieces though - splitting it into just readers or just writers still means that the first pr is very large (since it would still need all the shared code). Do you have any suggestions there? As to your questions, - These APIs are production ready (and are in fact being used in production at multiple organizations) - That makes sense to me from a code organization perspective. I can make that change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
