JulianJaffePinterest commented on pull request #10920: URL: https://github.com/apache/druid/pull/10920#issuecomment-881963079
@jihoonson I don't have the ability to create a branch in this repo to open prs against, but I'm game to try. It's been difficult to get reviews from committers (it took two months and multiple emails to the dev list to get the first review for this diff) and so I'm hesitant to go down a path of needing to hunt reviews for many diffs, but if you think smaller prs will actually get reviews I can do so. (As an aside, if the Druid website's [list of committers](https://druid.apache.org/community/) is accurate only 1 of the last 10 prs tagged "Design Review" actually had approval from three committers in GitHub, so some process improvements may be necessary) For documenting level of confidence in the various deep storage/metadata options, would you prefer an explicit table in the docs or in-line callouts (the current approach). I haven't updated .travis.yml beyond the checkstyle because the existing travis packages run the static checks and tests for the new module. In addition to unit tests, there's a light end-to-end test as well that writes segments out and then reads the created segments and confirms they match what was written. If there's actually a road for this pr, I can look into writing an integration test that requires an external spark cluster but obviously that won't be run as part of travis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
