vogievetsky commented on a change in pull request #11450:
URL: https://github.com/apache/druid/pull/11450#discussion_r673265385
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -224,7 +225,7 @@ interface RetentionDialogOpenOn {
interface CompactionDialogOpenOn {
readonly datasource: string;
- readonly compactionConfig: CompactionConfig;
+ readonly compactionConfig?: CompactionConfig;
Review comment:
Because a CompactionDialog can be open on a datasource without a
compaction config (like when one is being created for the first time). This was
already being set to `undefined` in some places, this change just makes the
issue more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
