suneet-s commented on a change in pull request #11450:
URL: https://github.com/apache/druid/pull/11450#discussion_r672802079
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1141,10 +1142,10 @@ ORDER BY 1`;
day_aligned_segments,
month_aligned_segments,
year_aligned_segments,
- } = original;
+ } = original as Datasource;
const segmentGranularities: string[] = [];
if (!num_segments || isNaN(year_aligned_segments)) return '-';
- if (num_segments - minute_aligned_segments) {
+ if (Number(num_segments) - minute_aligned_segments) {
Review comment:
should this be cast to `NumberLike` because of line 156?
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -224,7 +225,7 @@ interface RetentionDialogOpenOn {
interface CompactionDialogOpenOn {
readonly datasource: string;
- readonly compactionConfig: CompactionConfig;
+ readonly compactionConfig?: CompactionConfig;
Review comment:
Why this change and the ` | undefined` below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
